GNOME Bugzilla – Bug 795079
Update libarchive to >= 3.0
Last modified: 2018-04-25 08:58:49 UTC
libarchive 3.0 has been released in 2011 it's probably time to hide the deprecated symbols that have replacement since a long time. Here is a branch (also contains some data-array related changes) https://git.gnome.org/browse/vala/log/?h=wip/tintou/libarchive-v3 Related issue: #771916
Please preserve/fix the code-style for the touched lines. Keep using Posix.off_t and add array_length_type = "size_t" annotations for the uint8[] buffer parameters.
Created attachment 370965 [details] [review] libarchive: Add "has_typedef = false" attributes to delegates as needed
*** Bug 771916 has been marked as a duplicate of this bug. ***
Attachment 370965 [details] pushed as c535db7 - libarchive: Add "has_typedef = false" attributes to delegates as needed
Can you please fix Boxes? ../src/archive-writer.vala:126.33-126.36: error: Argument 1: Cannot convert from `void*' to `unowned uint8[]' if (archive.write_data (data, (size_t) len) != len) ^^^^ ../src/archive-writer.vala:75.35-75.86: error: 1 extra arguments for `ssize_t Archive.Read.read_data (uint8[])' insert_data (buf, archive_reader.archive.read_data (buf, (size_t) len)); (from https://gitlab.gnome.org/GNOME/gnome-build-meta/-/jobs/26658)
Created attachment 371362 [details] [review] libarchive: Fix 'buffer' ownership in read_data_block() and ReadCallback()
Comment on attachment 371362 [details] [review] libarchive: Fix 'buffer' ownership in read_data_block() and ReadCallback() Attachment 371362 [details] pushed as ee0d5a2 - libarchive: Fix 'buffer' ownership in read_data_block() and ReadCallback()