After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795065 - Fix linker options on Darwin
Fix linker options on Darwin
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: build
unspecified
Other All
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-04-08 06:47 UTC by Philip Chimento
Modified: 2018-04-09 06:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Correct Darwin linker options (806 bytes, patch)
2018-04-08 06:47 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2018-04-08 06:47:51 UTC 
Found this while building on macOS. The equal signs are not correct here.
Comment 1 Philip Chimento 2018-04-08 06:47:56 UTC 
Created attachment 370646 [details] [review]
build: Correct Darwin linker options

The Darwin linker doesn't want equal signs here.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-08 08:02:22 UTC 
Review of attachment 370646 [details] [review]:

I can't test it, but lgtm.
Comment 3 Philip Chimento 2018-04-08 22:52:20 UTC 
OK to commit it to gnome-3-28 as well?
Comment 4 Philip Chimento 2018-04-08 22:53:42 UTC 
Attachment 370646 [details] pushed as 0ae3ec7 - build: Correct Darwin linker options
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-09 06:13:19 UTC 
(In reply to Philip Chimento from comment #3)
> OK to commit it to gnome-3-28 as well?

Yeah, that's ok. Thanks.