After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795043 - Meson: Should generate a .pc file for each module
Meson: Should generate a .pc file for each module
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-04-07 01:17 UTC by Xavier Claessens
Modified: 2018-04-25 20:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Generate a .pc file for each module (1.85 KB, patch)
2018-04-07 01:19 UTC, Xavier Claessens 		committed Details | Review

Description Xavier Claessens 2018-04-07 01:17:47 UTC 
Similar to bug #794568, we should generate .pc file for each static module because we cannot rely on .la for that when built with meson.
Comment 1 Xavier Claessens 2018-04-07 01:19:49 UTC 
Created attachment 370618 [details] [review]
Generate a .pc file for each module

When static_modules is true, generate a .pc file to each module to be
able to get their private dependencies.

This uses a simplified pkg.generate() API added in Meson 0.46.0.
Comment 2 Xavier Claessens 2018-04-07 01:20:54 UTC 
Note this cannot be merged yet because Meson 0.46 will be released only next week.
Comment 3 Michael Catanzaro 2018-04-07 17:41:21 UTC 
Review of attachment 370618 [details] [review]:

Eh, OK... "accepted-commit_after_freeze" means whenever the new meson is available in gnome-build-meta.
Comment 4 Xavier Claessens 2018-04-23 20:44:00 UTC 
Meson 0.46 has been released, is it ok to push now ?
Comment 5 Philip Withnall 2018-04-23 21:05:46 UTC 
(In reply to Xavier Claessens from comment #4)
> Meson 0.46 has been released, is it ok to push now ?

Not until the BuildStream freedesktop-sdk builds it: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/base/meson.bst (used by https://gitlab.gnome.org/GNOME/gnome-build-meta).
Comment 6 Xavier Claessens 2018-04-23 21:50:43 UTC 
I'm from the old jhbuild school, how does it work to update meson there?
Comment 7 Michael Catanzaro 2018-04-23 23:56:05 UTC 
Update https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/base/meson.bst and send a merge request!

If you don't have a gitlab.com account, you could also poke CodeThink about it in #release-team.
Comment 8 Michael Catanzaro 2018-04-23 23:59:55 UTC 
(In reply to Philip Withnall from comment #5)
> Not until the BuildStream freedesktop-sdk builds it:
> https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/
> base/meson.bst (used by https://gitlab.gnome.org/GNOME/gnome-build-meta).

Almost forgot: you've just earned five release team brownie points! Yay!
Comment 9 Michael Catanzaro 2018-04-24 00:01:17 UTC 
(In reply to Michael Catanzaro from comment #7)
> Update
> https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/
> base/meson.bst and send a merge request!
> 
> If you don't have a gitlab.com account, you could also poke CodeThink about
> it in #release-team.

Maybe better to poke CodeThink, because whoever prepares the MR really ought to have access to the CI.
Comment 10 Xavier Claessens 2018-04-24 00:45:05 UTC 
Thanks, made the MR: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/209
Comment 11 Xavier Claessens 2018-04-25 20:10:04 UTC 
Attachment 370618 [details] pushed as 62362f9 - Generate a .pc file for each module