GNOME Bugzilla – Bug 795032
h265parse: Make caps writable before modifying them
Last modified: 2018-04-12 02:49:16 UTC
Fix following assertion failure GStreamer-CRITICAL **: gst_structure_remove_field: assertion 'IS_MUTABLE (structure)' failed
Created attachment 370589 [details] [review] h265parse: Make caps writable before modifying them
Can reproduce gst-launch-1.0 souphttpsrc location=http://media.w3.org/2010/05/sintel/trailer.mp4 ! qtdemux ! h264parse ! queue ! avdec_h264 ! queue ! videoconvert ! x265enc ! h265parse ! mpegtsmux ! fakesink
I see that in 1.14 too, just saying so we don't forget to backport.
Review of attachment 370589 [details] [review]: ::: gst/videoparsers/gsth265parse.c @@ +2270,2 @@ /* Try if we can put the downstream caps first */ + pcopy = gst_caps_copy (peercaps); There was I guess a reason to no use gst_caps_make_writable() ?
(In reply to Nicolas Dufresne (stormer) from comment #4) > Review of attachment 370589 [details] [review] [review]: > > ::: gst/videoparsers/gsth265parse.c > @@ +2270,2 @@ > /* Try if we can put the downstream caps first */ > + pcopy = gst_caps_copy (peercaps); > > There was I guess a reason to no use gst_caps_make_writable() ? Both gst_caps_make_writable() and gst_caps_copy() work well, but I just followed the h264parse version patch for consistency. https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=c0226e08e324fb416c2bb8eb95bb690152397f84
Queued for 1.14.1 Attachment 370589 [details] pushed as c65a537 - h265parse: Make caps writable before modifying them commit 3caf16a1994b55b4ca19e2d5802b6a60e0a1149c (HEAD -> master, origin/master, origin/HEAD) Author: Seungha Yang <pudding8757@gmail.com> Date: Fri Apr 6 23:22:39 2018 +0900 h265parse: Make caps writable before modifying them Fix following assertion failure GStreamer-CRITICAL **: gst_structure_remove_field: assertion 'IS_MUTABLE (structure)' failed https://bugzilla.gnome.org/show_bug.cgi?id=795032