GNOME Bugzilla – Bug 795018
Easytag loses other tags when saving
Last modified: 2018-04-06 07:25:42 UTC
Created attachment 370565 [details] [review] Reverse arguments to et_file_tag_copy_other_into, destination is first. I've found this issue with Fedora 27, 2.4.3-4. To reproduce: 1. extract a single track of a well-known CD in rhythmbox as FLAC 2. rhythmbox typically populates the following tags: album artist artistsort date discid discnumber genre musicbrainz_albumartistid musicbrainz_albumid musicbrainz_artistid musicbrainz_discid musicbrainz_trackid title tracknumber tracktotal 3. Open the track with easytag 4. Easytag will complain that the date is wrong (2018-01-01 while it wants 2018) and will mark the file as modified. 5. Save 6. The tag list is now: album artist date discnumber genre title tracknumber tracktotal All the unknown tags (musicbrainz-*, artistsort, discid) have been lost. I've tracked it to swapped arguments with calling et_file_tag_copy_other_into(), the source and destination have been swapped. With the attached patch, easytag functions correctly.
Review of attachment 370565 [details] [review]: Thanks for the bug report and patch! I pushed it to master as commit b00ed316550df3ae94522455f56e306e659511e5.