After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795015 - random dots after text
random dots after text
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-05 21:44 UTC by Samuel Thibault
Modified: 2018-04-06 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.81 KB, patch)
2018-04-05 21:44 UTC, Samuel Thibault 		none Details | Review
proposed fix (1.87 KB, patch)
2018-04-06 09:33 UTC, Samuel Thibault 		committed Details | Review

Description Samuel Thibault 2018-04-05 21:44:42 UTC 
Created attachment 370564 [details] [review]
proposed fix

Some random dots appear on the braille display. I'm attaching a proposed fix.
Comment 1 Joanmarie Diggs (IRC: joanie) 2018-04-06 01:48:04 UTC 
Review of attachment 370564 [details] [review]:

The way the code is now, we won't have any instances where submask is used before being defined. But I would still prefer it be initialized.
Comment 2 Samuel Thibault 2018-04-06 09:33:37 UTC 
Created attachment 370574 [details] [review]
proposed fix

Ok, so we could do this to make sure it always have a sane value?
Comment 3 Joanmarie Diggs (IRC: joanie) 2018-04-06 13:48:01 UTC 
(In reply to Samuel Thibault from comment #2)
> Created attachment 370574 [details] [review] [review]
> proposed fix
> 
> Ok, so we could do this to make sure it always have a sane value?

I'm a fan of sane values. ;)

Thanks for the patch. Committed: https://git.gnome.org/browse/orca/commit/?id=1bbccdc