After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794937 - release device when braille is deactivated for some applications
release device when braille is deactivated for some applications
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: braille
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-03 16:44 UTC by Samuel Thibault
Modified: 2018-04-03 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed implementation (1.83 KB, patch)
2018-04-03 16:44 UTC, Samuel Thibault
committed Details | Review

Description Samuel Thibault 2018-04-03 16:44:20 UTC
Created attachment 370491 [details] [review]
proposed implementation

Hello,

We are working on reading terminals with brltty, so we'd like to make orca release the device so brltty can get its output shown and get keypresses.

This can be achieved by setting the enableBraille preference to False for e.g. the mate-terminal application, and conversely making brltty only read terminals, so each screen readers leaves the room for the other as expected.

The attached patch implements the missing bit: shutdown() was not actually reaching the global _brlAPI variable, it should call closeConnection() to really close the connection, and setting _brlAPI to None so that the memory can be freed by the python garbage collector.

Then, on braille refresh we can check for the enableBraille settings, and if disabled (we have just switched to a terminal), we shut brlapi down if it was still running.

Samuel
Comment 1 Joanmarie Diggs (IRC: joanie) 2018-04-03 18:37:33 UTC
Comment on attachment 370491 [details] [review]
proposed implementation

Ok. https://git.gnome.org/browse/orca/commit/?id=71b6337

In the future, if it wouldn't be too much trouble, could you submit patches created with 'git format-patch'?

Regardless, thanks for the patch!