After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794904 - v4l2bufferpool: Try return input buffer sooner
v4l2bufferpool: Try return input buffer sooner
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-02 17:36 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-06-07 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2bufferpool: Try return input buffer soon (6.18 KB, patch)
2018-04-02 17:36 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2018-04-02 17:36:35 UTC 
The following patch is an experiment. It needs more testing, but the idea is
that if we have a v4l2 element importing from upstream (v4l2sink or v4l2transform)
then we want the buffers to be returned as soon as possible.

The current pool design was that it didn't matter leaving the unused buffers in the
queue as upstream would call acquire, but this does not work if upstream buffers
are imorted (e.g. upstream pushes dmabuf).
Comment 1 Nicolas Dufresne (ndufresne) 2018-04-02 17:36:41 UTC 
Created attachment 370449 [details] [review]
v4l2bufferpool: Try return input buffer soon

In this patch we use a non-blocking poll in order to return all input
buffers (buffers from v4l2-output queue). This prevent holding too long
on upstreaming buffer in importing.
Comment 2 Nicolas Dufresne (ndufresne) 2018-06-07 19:30:36 UTC 
Attachment 370449 [details] pushed as e943a11 - v4l2bufferpool: Try return input buffer soon