After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794897 - omxvideoenc: remove duplicated debug message
omxvideoenc: remove duplicated debug message
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-02 13:14 UTC by Guillaume Desmottes
Modified: 2018-04-02 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideoenc: remove duplicated debug message (993 bytes, patch)
2018-04-02 13:16 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2018-04-02 13:14:19 UTC 
.
Comment 1 Guillaume Desmottes 2018-04-02 13:16:48 UTC 
Created attachment 370439 [details] [review]
omxvideoenc: remove duplicated debug message

We already have the exact same message at the beginning of
gst_omx_video_enc_handle_frame(). Having it twice is confusing when
reading/grepping logs.

I kept the earlier one to keep the symetry with
gst_omx_video_dec_handle_frame().
Comment 2 Tim-Philipp Müller 2018-04-02 13:35:27 UTC 
I think you should feel free to just push trivial things like these now that you have commit access :)
Comment 3 Nicolas Dufresne (ndufresne) 2018-04-02 13:40:29 UTC 
Review of attachment 370439 [details] [review]:

.
Comment 4 Guillaume Desmottes 2018-04-02 14:13:49 UTC 
Attachment 370439 [details] pushed as dec9c8c - omxvideoenc: remove duplicated debug message
Comment 5 Guillaume Desmottes 2018-04-02 14:15:31 UTC 
(In reply to Tim-Philipp Müller from comment #2)
> I think you should feel free to just push trivial things like these now that
> you have commit access :)

Ok cool, I wasn't sure so preferred to ask first. :)

Pushed to 1.14 as well: fc22e10d89cd3f349cc64b29fb5eb7dbc8579f83