After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794872 - meson: Fix no-X11 documentation build
meson: Fix no-X11 documentation build
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2018-04-01 10:48 UTC by Quentin "Sardem FF7" Glidic
Modified: 2018-04-25 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to declare the variable as a no-op for no-X11 builds (697 bytes, patch)
2018-04-01 10:49 UTC, Quentin "Sardem FF7" Glidic
committed Details | Review

Description Quentin "Sardem FF7" Glidic 2018-04-01 10:48:45 UTC
When building with -Ddocs=true -Dx11=false, the configure phase fails with:
docs/reference/gdk-pixbuf/meson.build:30:8: ERROR:  Unknown variable "gdkpixbuf_xlib_inc"
It was introduced in commit 204082e6a7a404ec7372d78ef7a7890ada595154, where the meson.build file setting this variable was called conditionally.
Comment 1 Quentin "Sardem FF7" Glidic 2018-04-01 10:49:49 UTC
Created attachment 370407 [details] [review]
Patch to declare the variable as a no-op for no-X11 builds
Comment 2 Emmanuele Bassi (:ebassi) 2018-04-25 14:58:54 UTC
Review of attachment 370407 [details] [review]:

:thumbsup:
Comment 3 Emmanuele Bassi (:ebassi) 2018-04-25 15:37:32 UTC
Pushed to master