After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794861 - Bookmark UI is too wide on some locales
Bookmark UI is too wide on some locales
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-31 13:57 UTC by Alexander Mikhaylenko
Modified: 2018-03-31 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (44.64 KB, image/png)
2018-03-31 13:57 UTC, Alexander Mikhaylenko 		  Details
Screenshot with English locale (41.43 KB, image/png)
2018-03-31 14:00 UTC, Alexander Mikhaylenko 		  Details
bookmarks-popover: Wrap empty state subtitle (1.17 KB, patch)
2018-03-31 15:20 UTC, Alexander Mikhaylenko 		committed Details | Review
Screenshot of the changes (45.23 KB, image/png)
2018-03-31 16:02 UTC, Alexander Mikhaylenko 		  Details

Description Alexander Mikhaylenko 2018-03-31 13:57:37 UTC 
Created attachment 370383 [details]
Screenshot

At least with Russian locale, bookmark popover has some unnecessary padding that
isn't there with English.
Comment 1 Alexander Mikhaylenko 2018-03-31 14:00:50 UTC 
Created attachment 370384 [details]
Screenshot with English locale
Comment 2 Alexander Mikhaylenko 2018-03-31 14:13:38 UTC 
It seems it's caused by label on blank state being too wide and not wrapping.
Comment 3 Alexander Mikhaylenko 2018-03-31 15:20:00 UTC 
Created attachment 370387 [details] [review]
bookmarks-popover: Wrap empty state subtitle

Prevents popover from getting too wide with some locales.
Comment 4 Michael Catanzaro 2018-03-31 15:42:22 UTC 
Review of attachment 370387 [details] [review]:

Thanks
Comment 5 Michael Catanzaro 2018-03-31 15:42:42 UTC 
Do you have a git account yet? Need me to commit?
Comment 6 Alexander Mikhaylenko 2018-03-31 15:45:03 UTC 
> Need me to commit?
Yes
Comment 7 Michael Catanzaro 2018-03-31 15:47:14 UTC 
Attachment 370387 [details] pushed as bd34ee2 - bookmarks-popover: Wrap empty state subtitle
Comment 8 Michael Catanzaro 2018-03-31 15:49:37 UTC 
Can you post a couple screenshots of the empty state (English and Russian locales)? Just to be sure it still looks good.
Comment 9 Alexander Mikhaylenko 2018-03-31 16:02:37 UTC 
Created attachment 370390 [details]
Screenshot of the changes

Sure. On the bottom is how it was before.
Comment 10 Michael Catanzaro 2018-03-31 17:53:54 UTC 






Comment 11


Michael Catanzaro





          2018-03-31 17:54:21 UTC
        



(In reply to Michael Catanzaro from comment #10)
> 

That was supposed to be a thumbs-up sign, but Bugzilla decided to change it into an empty comment. :(