After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794824 - openssl: Set openssl_platform for ARM linux
openssl: Set openssl_platform for ARM linux
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-29 22:56 UTC by Omar Akkila
Modified: 2018-04-17 19:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
openssl: set openssl_platform for ARM-based linux platforms (1.20 KB, patch)
2018-03-29 22:58 UTC, Omar Akkila 		needs-work Details | Review
openssl: set openssl_platform for ARM Linux (1.18 KB, patch)
2018-04-17 18:33 UTC, Omar Akkila 		committed Details | Review

Description Omar Akkila 2018-03-29 22:56:55 UTC 
For Linux platforms, the `openssl_platform` variable in `recipes/openssl.recipe` is set only for x86 and x86_64 architectures and anything else raises a `NotImplementedError`. We can set the platform for ARM linux based on openssl's config script (https://git.openssl.org/?p=openssl.git;a=blob;f=config;h=ce993021867a76368c73db5981dc3484e2d63dd1;hb=HEAD).
Comment 1 Omar Akkila 2018-03-29 22:58:37 UTC 
Created attachment 370317 [details] [review]
openssl: set openssl_platform for ARM-based linux platforms
Comment 2 Olivier Crête 2018-04-17 17:49:57 UTC 
Review of attachment 370317 [details] [review]:

::: recipes/openssl.recipe
@@ +67,3 @@
                 self.openssl_platform = 'linux-x86_64'
+            elif self.config.target_arch == Architecture.ARM:
+                self.openssl_platform = 'linux-generic32'

our Architecture.ARM means ARMv6, so same default as ARMv7
Comment 3 Omar Akkila 2018-04-17 18:33:50 UTC 
Created attachment 371066 [details] [review]
openssl: set openssl_platform for ARM Linux
Comment 4 Olivier Crête 2018-04-17 18:42:44 UTC 
Review of attachment 371066 [details] [review]:

::: recipes/openssl.recipe
@@ +71,3 @@
+                self.openssl_platform = 'linux-armv4'
+            elif self.config.target_arch == Architecture.ARMv7:
+                self.openssl_platform = 'linux-armv4'

elif A or B:
Comment 5 Olivier Crête 2018-04-17 19:21:35 UTC 
Attachment 371066 [details] pushed as 24c24a8 - openssl: set openssl_platform for ARM Linux

Seems like other parts of the same recipe follow the same style, so let's merge it as-is.