After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794810 - webrtcbin does not handle ICE candidates in SDP sent via set-remote-description signal
webrtcbin does not handle ICE candidates in SDP sent via set-remote-descripti...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.14.0
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-29 13:57 UTC by Daniel F
Modified: 2018-11-03 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel F 2018-03-29 13:57:44 UTC
According to JSEP section 5.10 (Applying a Remote Description), this is a MUST:
"Pair any supplied ICE candidates with any gathered local
candidates, as described in [RFC5245], Section 5.7, and start
connectivity checks with the appropriate credentials."

webrtc currently does not do this, app has to extract candidates from remote SDP and sent them one by one to webrtcbin via add-ice-candidate signal.
Comment 1 Nicolas Dufresne (ndufresne) 2018-03-29 14:30:33 UTC
Good point, I've seen cases where all the candidates were in the SDP, so these case would break.

While at it, does the async candidates are always one by one ? I thought you could pass multiple candidates, so maybe we should add add-ice-candiates ? Ideally, we should never have to parse the WebRTC blobs really.
Comment 2 Daniel F 2018-03-29 14:38:26 UTC
on-ice-candidate reports candidates one by one, so I assumed that the same is needed for add-ice-candidate. I did not check what JSEP says about this.
Comment 3 GStreamer system administrator 2018-11-03 14:20:17 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/678.