After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794778 - adding ScrollTo to at-spi
adding ScrollTo to at-spi
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pyatspi2 maintainer(s)
pyatspi2 maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-03-28 18:07 UTC by Samuel Thibault
Modified: 2018-05-17 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed implementation (7.54 KB, patch)
2018-03-28 18:07 UTC, Samuel Thibault 		none Details | Review
proposed implementation (2.93 KB, patch)
2018-03-30 10:52 UTC, Samuel Thibault 		none Details | Review
proposed implementation (3.08 KB, patch)
2018-05-02 09:53 UTC, Samuel Thibault 		none Details | Review
proposed implementation (3.08 KB, patch)
2018-05-02 13:07 UTC, Samuel Thibault 		none Details | Review

Description Samuel Thibault 2018-03-28 18:07:29 UTC 
Created attachment 370256 [details] [review]
proposed implementation

Here is a proposed pyatspi implementation for scrollto, as discussed in https://bugzilla.gnome.org/show_bug.cgi?id=792820
Comment 1 Mike Gorse 2018-03-30 10:08:37 UTC 
I think that you uploaded the wrong patch.
Comment 2 Samuel Thibault 2018-03-30 10:52:12 UTC 
Created attachment 370336 [details] [review]
proposed implementation

D'oh!
It looks like the new behavior of the gtk file chooser brings bogus results. I remember typing "patch" and perhaps use arrows to choose the "patch" file, but apparently it took the first file in the directory, 50_partial_file_locking.patch...
Comment 3 Mike Gorse 2018-03-30 17:43:40 UTC 
Comment on attachment 370336 [details] [review]
proposed implementation

Lgtm. (At some point, I should figure out if these enums can be handled without needing to write all of this code in parallel. But then pyatspi really just exists for historical reasons--it is possible to call libatspi directly via pygobject.
Comment 4 Samuel Thibault 2018-05-02 09:53:57 UTC 
Created attachment 371605 [details] [review]
proposed implementation

Here is a patch generated with format-patch
Comment 5 Samuel Thibault 2018-05-02 13:07:34 UTC 
Created attachment 371614 [details] [review]
proposed implementation

Sorry, that was a version for an older tree, here it is fixed.
Comment 6 Mike Gorse 2018-05-17 01:53:37 UTC 
Pushed to master.