After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794777 - Several fixes to the introspection
Several fixes to the introspection
Status: RESOLVED FIXED
Product: libgsf
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2018-03-28 17:37 UTC by Corentin Noël
Modified: 2018-04-11 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix several annotations (17.05 KB, patch)
2018-03-28 17:38 UTC, Corentin Noël 		none Details | Review
Several GObject introspection fixes (17.00 KB, patch)
2018-03-28 19:09 UTC, Corentin Noël 		none Details | Review
Several GObject introspection fixes (17.01 KB, patch)
2018-03-28 21:42 UTC, Corentin Noël 		none Details | Review
GObject Introspection: fix several annotations (16.80 KB, patch)
2018-04-06 16:01 UTC, Rico Tzschichholz 		none Details | Review

Description Corentin Noël 2018-03-28 17:37:28 UTC 
Here is a patch solving some introspection issues
Comment 1 Corentin Noël 2018-03-28 17:38:04 UTC 
Created attachment 370255 [details] [review]
Fix several annotations
Comment 2 Corentin Noël 2018-03-28 19:09:09 UTC 
Created attachment 370260 [details] [review]
Several GObject introspection fixes
Comment 3 Corentin Noël 2018-03-28 21:42:48 UTC 
Created attachment 370268 [details] [review]
Several GObject introspection fixes
Comment 4 Corentin Noël 2018-03-28 21:43:50 UTC 
The last attachments contains some feedbacks from Vala maintainers (my .gir was wrong on the previous patches)
Comment 5 Morten Welinder 2018-03-29 17:46:23 UTC 
What kind of testing has these bindings seen?
What version of introspection do the patches depend on?

I ask because we have been hit by introspection bugs before.


This fragment looks weird.  Why is this changed to "transfer none"?

 /**
- * gsf_input_dup:
+ * gsf_input_dup: (virtual Dup):
  * @input: The input to duplicate
  * @err: (allow-none): place to store a #GError if anything goes wrong
  *
  * Duplicates input @src leaving the new one at the same offset.
  *
- * Returns: (transfer full): the duplicate, or %NULL on error
+ * Returns: (transfer none): the duplicate, or %NULL on error
  **/
 GsfInput *
 gsf_input_dup (GsfInput *input, GError **err)
Comment 6 Rico Tzschichholz 2018-04-06 16:01:48 UTC 
Created attachment 370601 [details] [review]
GObject Introspection: fix several annotations
Comment 7 Morten Welinder 2018-04-11 00:13:52 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.