After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794728 - Epiphany SIGSEVs in ephy_web_extension_destroy_sync_service at "../embed/web-extension/ephy-web-extension.c"
Epiphany SIGSEVs in ephy_web_extension_destroy_sync_service at "../embed/web-...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Sync
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-27 14:00 UTC by Andres Gomez
Modified: 2018-03-27 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
BT from gdb for epiphany (103.18 KB, text/plain)
2018-03-27 14:00 UTC, Andres Gomez 		  Details
web-extension: Null-check before destroying sync service (903 bytes, patch)
2018-03-27 15:05 UTC, Michael Catanzaro 		committed Details | Review

Description Andres Gomez 2018-03-27 14:00:47 UTC 
Created attachment 370193 [details]
BT from gdb for epiphany

I'm using epiphany 3.27.90-38-gdb76a7f with WebKitGtk+ 2.19.92 from gnome-nightly's flatpak.

With epiphany already running, I clicked in an email in Evolution in a link to: https://twitter.com/AmazonEnLucha

When I went to the newly opened tab, it was showing the usual:

"Oops!
Something went wrong while displaying this page.

Please reload or visit a different page to continue."

Message.
Comment 1 Andres Gomez 2018-03-27 14:02:18 UTC 
Forgot to mention that this is a core from:
/newroot/usr/libexec/webkit2gtk-4.0/WebKitWebProcess

So, not sure this belongs to Ephy.
Comment 2 Andres Gomez 2018-03-27 14:04:14 UTC 
FTR, if I click "Reload" in the crashed tab, it reloads without problems.
Comment 3 Michael Catanzaro 2018-03-27 14:41:47 UTC 
(In reply to Andres Gomez from comment #1)
> Forgot to mention that this is a core from:
> /newroot/usr/libexec/webkit2gtk-4.0/WebKitWebProcess
> 
> So, not sure this belongs to Ephy.

This is an Epiphany web extension bug, not a WebKit bug. You got the right place!
Comment 4 Michael Catanzaro 2018-03-27 15:05:55 UTC 
Created attachment 370200 [details] [review]
web-extension: Null-check before destroying sync service
Comment 5 Michael Catanzaro 2018-03-27 15:06:14 UTC 
(In reply to Michael Catanzaro from comment #4)
> Created attachment 370200 [details] [review] [review]
> web-extension: Null-check before destroying sync service

(Gabriel, does it look right?)
Comment 6 Gabriel Ivașcu 2018-03-27 15:15:02 UTC 
Review of attachment 370200 [details] [review]:

Yes, that looks just right. Thank you for fixing it!
Comment 7 Michael Catanzaro 2018-03-27 15:22:56 UTC 
Attachment 370200 [details] pushed as 7588e29 - web-extension: Null-check before destroying sync service