After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794681 - Remove auto-open downloads feature
Remove auto-open downloads feature
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-25 21:35 UTC by Michael Catanzaro
Modified: 2019-11-21 21:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove auto-open downloads feature (8.34 KB, patch)
2018-03-25 21:43 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2018-03-25 21:35:59 UTC 
This is inherently unsafe because a webpage can download a malicious file without user interaction, and trust it will open automatically in a vulnerable application.

Posting this for feedback. I know Michael is using this feature, for instance. Would you miss it?
Comment 1 Michael Catanzaro 2018-03-25 21:43:26 UTC 
CCing people for opinions
Comment 2 Michael Catanzaro 2018-03-25 21:43:31 UTC 
Created attachment 370128 [details] [review]
Remove auto-open downloads feature

This is inherently unsafe because a webpage can download a malicious
file without user interaction, and trust it will open automatically in
a vulnerable application.

We will continue to download files automatically, despite the various
Chrome hacks from last year proving that this can be abused via tracker
and GNOME desktop thumbnailers. Tracker now mitigates this risk using
libseccomp, and GNOME desktop thumbnailers are now run under bubblewrap.
Comment 3 Michael Gratton 2018-03-26 05:19:36 UTC 
This would indeed make me a bit sad - it's pretty handy. Is it possible to auto-open only in response to an explicit user action?
Comment 4 Andres Gomez 2018-03-26 10:09:38 UTC 
(In reply to Michael Catanzaro from comment #0)

...

> Posting this for feedback. I know Michael is using this feature, for
> instance. Would you miss it?

I've never had this option activated in any of my browsers ever. I won't miss it and the reasons why I don't have it activated are the same ones why it shouldn't even be available.

Thanks for bringing up this bug, Michael.
Comment 5 Alexander Mikhaylenko 2018-03-26 10:22:22 UTC 
I never had this enabled either.
Comment 6 Michael Catanzaro 2018-03-26 15:44:53 UTC 
(In reply to Michael Gratton from comment #3)
> This would indeed make me a bit sad - it's pretty handy. Is it possible to
> auto-open only in response to an explicit user action?

I don't think it is possible.
Comment 7 Jan-Michael Brummer 2018-03-27 06:56:08 UTC 
IMHO remove this feature, i have never enabled it.
Comment 8 Michael Catanzaro 2018-03-29 23:43:35 UTC 
Going to go ahead with this.
Comment 9 Michael Catanzaro 2018-03-29 23:44:15 UTC 
Attachment 370128 [details] pushed as a41416c - Remove auto-open downloads feature
Comment 10 Bachsau 2018-04-16 13:38:16 UTC 
Removing features is almost always a bad idea. A warning displayed when a user enables the function would do.