GNOME Bugzilla – Bug 794654
encodebin: Forward upstream force-key-unit events to encoder
Last modified: 2018-11-03 12:04:37 UTC
StreamCombiner element forwards a upstream event only to one sinkpad. Unfortunately, a sinkpad corresponding to pass-through path is configured before that of encoder, StreamCombiner forwards upstream events only to the firstly configured one (i.e., pass-through path).
Created attachment 370084 [details] [review] [1/2] encodebin: Use gst_object_unref() instead of g_object_unref() ... for better debugging (e.g., tracing refcount)
Created attachment 370085 [details] [review] [2/2] encodebin: Forward upstream force-key-unit events to encoder
Review of attachment 370085 [details] [review]: Why don't we make sure the streamcombiner forward KEY_UNIT events to all it sinkpads instead?
commit 07eab6de3f3ec3058a5a47a1481ec34faee60d54 (HEAD -> master, origin/master, origin/HEAD) Author: Seungha Yang <pudding8757@gmail.com> Date: Sat Mar 24 21:35:07 2018 +0900 encodebin: Use gst_object_unref() instead of g_object_unref() ... for better debugging (e.g., tracing refcount) https://bugzilla.gnome.org/show_bug.cgi?id=794654
(In reply to Thibault Saunier from comment #3) > Review of attachment 370085 [details] [review] [review]: > > Why don't we make sure the streamcombiner forward KEY_UNIT events to all it > sinkpads instead? Although streamcombiner seems to be internal element of encodebin, I'm not sure whether adding such behavior in streamcombiner is good or not, since we might need more events in the future which requires this kinds of approach. Can we use funnel instead?
Created attachment 370949 [details] [review] streamcombiner: Forward upstream force-key-unit events to all sinkpads
Created attachment 370950 [details] [review] streamsplitter: Drop duplicated force-key-unit events
(In reply to Thibault Saunier from comment #3) > Review of attachment 370085 [details] [review] [review]: > > Why don't we make sure the streamcombiner forward KEY_UNIT events to all it > sinkpads instead? I updated patch to forward upstream key unit event to all sinkpads. And streamsplitter will drop duplicated events based on event sequence number.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/429.