After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794638 - “Open Shape Layer…” is not translated
“Open Shape Layer…” is not translated
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.28.x
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-23 20:13 UTC by Piotr Drąg
Modified: 2018-03-25 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screencast of the issue (81.21 KB, image/png)
2018-03-23 20:13 UTC, Piotr Drąg 		  Details
layers-popover: Use a regular ellipsis in a string (1.30 KB, patch)
2018-03-23 20:16 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2018-03-23 20:13:56 UTC 
Created attachment 370065 [details]
Screencast of the issue

The button “Open Shape Layer…” is not translated.
Comment 1 Piotr Drąg 2018-03-23 20:16:56 UTC 
Created attachment 370066 [details] [review]
layers-popover: Use a regular ellipsis in a string

It seems that gettext doesn’t like … in there and refuses to show the translation.
Comment 2 Marcus Lundblad 2018-03-24 14:47:32 UTC 
Review of attachment 370066 [details] [review]:

LGTM
Comment 3 Marcus Lundblad 2018-03-24 14:51:40 UTC 
Thanks for the patch!
I changed the headline, I prefer camelCase for module names, as this is how we name the .js implementation files.
Comment 4 Piotr Drąg 2018-03-24 16:53:23 UTC 
Thank you. Could you push also to gnome-3-28? It wouldn’t be a string freeze break.
Comment 5 Marcus Lundblad 2018-03-25 07:28:19 UTC 
(In reply to Piotr Drąg from comment #4)
> Thank you. Could you push also to gnome-3-28? It wouldn’t be a string freeze
> break.

I think this might need a string freeze break request on the 3.28 branch?
Comment 6 Piotr Drąg 2018-03-25 18:25:08 UTC 
It doesn’t, it’s covered by “Marking a message for translation that was previously not marked for translation by accident.”