After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794627 - Meson: drop library_format option to build both shared and static
Meson: drop library_format option to build both shared and static
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 794604
 
 
Reported: 2018-03-23 15:28 UTC by Xavier Claessens
Modified: 2018-04-24 23:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Meson: Use library() to build both static and shared libs (15.37 KB, patch)
2018-03-23 17:48 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2018-03-23 15:28:08 UTC
Once this PR gets merged/release in Meson:
https://github.com/mesonbuild/meson/pull/2711

Then instead of using shared_library() and static_library() we can use just library() and it will build both shared and static when passing option --default-library=both. Bonus, it will compile only once instead of building everything twice like current GStreamer's library_format=both option.
Comment 1 Xavier Claessens 2018-03-23 17:48:31 UTC
Created attachment 370060 [details] [review]
Meson: Use library() to build both static and shared libs

Meson supports building both static and shared libraries in a single
library() call. It has the advantage of reusing the same .o objects and
thus avoid double compilation.
Comment 2 Tim-Philipp Müller 2018-03-23 18:07:51 UTC
Nice. We'll also need this in a Meson release though as we don't want to depend on Meson from git.
Comment 3 Tim-Philipp Müller 2018-04-24 23:44:00 UTC
commit b00b1d536141b00fa196639630b0d43d72b9fb55
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Fri Mar 23 12:48:37 2018 -0400

    Meson: Use library() to build both static and shared libs
    
    Meson supports building both static and shared libraries in a single
    library() call. It has the advantage of reusing the same .o objects and
    thus avoid double compilation.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=794627