After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794613 - Updating gstreamer version in custom.py doesn't cause rebuild
Updating gstreamer version in custom.py doesn't cause rebuild
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other All
: Normal major
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-23 00:25 UTC by Nirbheek Chauhan
Modified: 2018-03-23 06:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cerbero: Check built version while loading recipe (1.55 KB, patch)
2018-03-23 04:14 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2018-03-23 00:25:56 UTC 
Ever since we started defining the version for gstreamer recipes in recipes/custom.py, updating that version doesn't trigger a rebuild. This means if you rebuild, say, a gst-plugins-bad-1.0, if gstreamer-1.0 was already built as a previous version, the configure will fail.

The workaround is to issue `buildone` on all recipes.

This is especially bad because this means the recipes won't get rebuilt and updated to the actual code in git while packaging.
Comment 1 Nirbheek Chauhan 2018-03-23 00:46:54 UTC 
We should check whether our binary releases have plugin versions as 1.14 or not. This might have caused them to not have the latest code.
Comment 2 Nirbheek Chauhan 2018-03-23 03:06:34 UTC 
(In reply to Nirbheek Chauhan from comment #1)
> We should check whether our binary releases have plugin versions as 1.14 or
> not. This might have caused them to not have the latest code.

I checked all the 1.14 binary releases for all the platforms. The gstreamer versions looked correct. I verified by checking the version in all the pkgconfig files.
Comment 3 Nirbheek Chauhan 2018-03-23 04:14:20 UTC 
Created attachment 370045 [details] [review]
cerbero: Check built version while loading recipe

If the built version of a recipe is different than the current
version, reset the status and force a rebuild.
Comment 4 Nirbheek Chauhan 2018-03-23 04:15:01 UTC 
Attachment 370045 [details] pushed as 8e084f9 - cerbero: Check built version while loading recipe
Comment 5 Jan Schmidt 2018-03-23 06:16:38 UTC 
When I do release builds, I do a full wipe first.