After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794592 - adaptivedemux: Use bps units for connection-speed property
adaptivedemux: Use bps units for connection-speed property
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-22 10:23 UTC by hosang
Modified: 2018-03-22 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use bps units for connection-speed property (2.46 KB, patch)
2018-03-22 10:23 UTC, hosang 		none Details | Review

Description hosang 2018-03-22 10:23:33 UTC 
Created attachment 369998 [details] [review]
Use bps units for connection-speed property

Using kbps units causes unnecessary conversions when setting the property and when using the value for bitrate comparisons.
Comment 1 hosang 2018-03-22 10:24:35 UTC 
Is there a reason for connection-speed property to be in kbps units?
It is unnecessarily being converted to bps again, so I feel it is better for this property to be in bps units.

Also, normally player applications will do their own bitrate calculations in bps units,
so when it tries to use this property, they will also have to convert values to kbps units unnecessarily.

Any advice will be helpful.
Comment 2 Tim-Philipp Müller 2018-03-22 10:41:05 UTC 
This change would not be backwards compatible, and it doesn't really seem worth it to me either :)
Comment 3 hosang 2018-03-22 10:55:16 UTC 
Okay, then is there any reason for it to be in kbps units?
Comment 4 Sebastian Dröge (slomo) 2018-03-22 13:50:56 UTC 
All other connect-speed properties are in the same unit, and back in ancient times someone decided that way :)
Comment 5 Tim-Philipp Müller 2018-03-22 14:07:15 UTC 
Thanks for the patch, but I don't think we can change this now.