After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794583 - Build failure with commit 8ee306e
Build failure with commit 8ee306e
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-21 22:12 UTC by jayeshece08
Modified: 2018-03-21 22:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description jayeshece08 2018-03-21 22:12:28 UTC
https://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=8ee306eb3fb69c34c579874f6aedcecb6d94a855 is breaking the build.

Snip:
21:44:21,429 INFO  - libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../.. -I/opt/media/install/include -I../../../gst-libs -I../../../gst-libs -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/opt/media/install/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -Werror -g -DGST_DISABLE_DEPRECATED -fvisibility=hidden -g3 -MT libgstallocators_1.0_la-gstphysmemory.lo -MD -MP -MF .deps/libgstallocators_1.0_la-gstphysmemory.Tpo -c gstphysmemory.c -fPIC -DPIC -o .libs/libgstallocators_1.0_la-gstphysmemory.o
21:44:21,521 INFO  - gstdmabuf.c: In function 'gst_dmabuf_mem_map':
21:44:21,521 INFO  - gstdmabuf.c:62:3: error: 'ret' undeclared (first use in this function)
21:44:21,522 INFO  - ret = allocator->mem_map (gmem, maxsize, info->flags);
21:44:21,522 INFO  - ^
21:44:21,522 INFO  - gstdmabuf.c:62:3: note: each undeclared identifier is reported only once for each function it appears in
21:44:21,523 INFO  - gstdmabuf.c:73:1: error: control reaches end of non-void function [-Werror=return-type]
21:44:21,523 INFO  - }
21:44:21,523 INFO  - ^
21:44:21,523 INFO  - cc1: all warnings being treated as errors
21:44:21,527 INFO  - Makefile:747: recipe for target 'libgstallocators_1.0_la-gstdmabuf.lo' failed
21:44:21,527 INFO  - make[4]: *** [libgstallocators_1.0_la-gstdmabuf.lo] Error 1
21:44:21,527 INFO  - make[4]: *** Waiting for unfinished jobs....
21:44:21,564 INFO  - mv -f .deps/libgstallocators_1.0_la-gstphysmemory.Tpo .deps/libgstallocators_1.0_la-gstphysmemory.Plo
21:44:21,650 INFO  - mv -f .deps/libgstallocators_1.0_la-gstfdmemory.Tpo .deps/libgstallocators_1.0_la-gstfdmemory.Plo
21:44:21,653 INFO  - make[4]: Leaving directory '/opt/media/build/gst-plugins-base/gst-libs/gst/allocators'
21:44:21,655 INFO  - Makefile:659: recipe for target 'all-recursive' failed
21:44:21,655 INFO  - make[3]: *** [all-recursive] Error 1
21:44:21,655 INFO  - make[3]: Leaving directory '/opt/media/build/gst-plugins-base/gst-libs/gst'
21:44:21,656 INFO  - Makefile:624: recipe for target 'all-recursive' failed
21:44:21,656 INFO  - make[2]: *** [all-recursive] Error 1
21:44:21,656 INFO  - make[2]: Leaving directory '/opt/media/build/gst-plugins-base/gst-libs'
21:44:21,657 INFO  - Makefile:748: recipe for target 'all-recursive' failed
21:44:21,657 INFO  - make[1]: *** [all-recursive] Error 1
21:44:21,657 INFO  - make[1]: Leaving directory '/opt/media/build/gst-plugins-base'
21:44:21,657 INFO  - Makefile:679: recipe for target 'all' failed
21:44:21,657 INFO  - make: *** [all] Error 2
21:44:21,657 INFO  - err: "make -j 88" failed - exitcode 2
21:44:21,658 INFO  - aborting...

Analysis:
On a build machine with : HAVE_LINUX_DMA_BUF_H not defined, the build is breaking due to non-definition of 'ret'

https://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/allocators/gstdmabuf.c?id=8ee306eb3fb69c34c579874f6aedcecb6d94a855#n53
Comment 1 Nicolas Dufresne (ndufresne) 2018-03-21 22:19:57 UTC
Hello, we already have CI and notification for this in IRC, it's not required to file a bug if the CI is red.

  ci.gstreamer.net

Thanks.

Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed Mar 21 18:15:49 2018 -0400

    dmabufallocator: Fix build if LINUX_DMA_BUF_H is missing