After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794565 - Drop some old stuff
Drop some old stuff
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-21 13:40 UTC by Egmont Koblinger
Modified: 2018-03-21 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop prefs migrator (and gconf dependency) (27.88 KB, patch)
2018-03-21 13:43 UTC, Egmont Koblinger
committed Details | Review
Drop dead code (esp. mc integration) (11.27 KB, patch)
2018-03-21 13:47 UTC, Egmont Koblinger
committed Details | Review

Description Egmont Koblinger 2018-03-21 13:40:00 UTC
Drop:

- dconf->gconf migration (see bug 792990)

- mc integration: has been disabled for at least 6-7 years, allows some code cleanup

- --load-config option, has no corresponding save-config, probably also a leftover from years ago
Comment 1 Egmont Koblinger 2018-03-21 13:43:57 UTC
Created attachment 369961 [details] [review]
Drop prefs migrator (and gconf dependency)
Comment 2 Egmont Koblinger 2018-03-21 13:47:24 UTC
Created attachment 369962 [details] [review]
Drop dead code (esp. mc integration)

Drop some long-dead code mostly around mc integration, a bit around desktop_{is,opens}_home_dir.
Comment 3 Egmont Koblinger 2018-03-21 14:07:05 UTC
> - --load-config option, has no corresponding save-config, probably also a
> leftover from years ago

It's related to some automatic session management, restoring the windows after a crash or similar. See e.g. bug 586308, and the hidden --sm-whatever config options (smclient_goptions[] in the source).

(No clue _how_ the settings are saved, though.)

Does this thing still exist in GNOME, or is it dead stuff?
Comment 4 Christian Persch 2018-03-21 18:06:33 UTC
There's a request (bug 766503) about bringing back --save-config, so I'd say let's keep the --load-config (also you could hand-craft the file).
Comment 5 Egmont Koblinger 2018-03-21 20:43:27 UTC
> There's a request (bug 766503) about bringing back --save-config, so I'd say
> let's keep the --load-config (also you could hand-craft the file).

Okay.

Changes submitted, so closing.