After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794555 - glib meson build fails on MinGW due to misdetected functions
glib meson build fails on MinGW due to misdetected functions
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 790954
 
 
Reported: 2018-03-21 09:57 UTC by LRN
Modified: 2018-05-04 23:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check stpcpy() and posix_memalign() to *not* to be built-in (1.86 KB, patch)
2018-03-21 09:57 UTC, LRN 		committed Details | Review

Description LRN 2018-03-21 09:57:14 UTC 
Meson incorrectly detects stpcpy() and posix_memalign() functions to be
availabe due to the fact that gcc has built-ins that kick in for the
simple cases that the normal meson function test source code presents.
Comment 1 LRN 2018-03-21 09:57:21 UTC 
Created attachment 369946 [details] [review]
Check stpcpy() and posix_memalign() to *not* to be built-in

GCC has built-ins for these functions, which might give a compile-only
test an impression that the functions are actually present in the C runtime.
Use a linked test to be sure.

Specifically, both functions are missing on Windows.
Comment 2 Emmanuele Bassi (:ebassi) 2018-03-28 11:10:09 UTC 
Review of attachment 369946 [details] [review]:

Okay
Comment 3 LRN 2018-03-28 11:48:28 UTC 
Attachment 369946 [details] pushed as dcc452b - Check stpcpy() and posix_memalign() to *not* to be built-in
Comment 4 Christoph Reiter (lazka) 2018-04-24 13:00:46 UTC 
The stpcpy check doesn't seem to work under MSYS2, any ideas? https://gitlab.gnome.org/creiter/glib/-/jobs/26603
Comment 5 Philip Withnall 2018-04-25 12:07:44 UTC 
(In reply to Christoph Reiter (lazka) from comment #4)
> The stpcpy check doesn't seem to work under MSYS2, any ideas?
> https://gitlab.gnome.org/creiter/glib/-/jobs/26603

I think that became attachment #371365 [details] on bug #793729, right?
Comment 6 Christoph Reiter (lazka) 2018-04-25 15:37:03 UTC 
(In reply to Philip Withnall from comment #5)
> (In reply to Christoph Reiter (lazka) from comment #4)
> > The stpcpy check doesn't seem to work under MSYS2, any ideas?
> > https://gitlab.gnome.org/creiter/glib/-/jobs/26603
> 
> I think that became attachment #371365 [details] on bug #793729, right?

Yes.
Comment 7 Xavier Claessens 2018-05-04 23:29:22 UTC 
I've seen this bug linked in a meson report: https://github.com/mesonbuild/meson/issues/3482

I don't know what's it's about, but does it mean a better fix is possible than the one merged? Nirbeek, can you please comment what glib should do if meson is fixed?