After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794470 - Set additional file attributes in mtp backend
Set additional file attributes in mtp backend
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: mtp backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Philip Langdale
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-18 21:30 UTC by Philip Langdale
Modified: 2018-03-20 03:14 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Set more attributes (4.90 KB, patch)
2018-03-18 21:30 UTC, Philip Langdale 		accepted-commit_now Details | Review

Description Philip Langdale 2018-03-18 21:30:59 UTC 
Created attachment 369846 [details] [review]
Set more attributes

We could usefully set some additional file attributes in the mtp backend - particularly the symbolic icon and the file id.
Comment 1 Ondrej Holy 2018-03-19 09:48:09 UTC 
Review of attachment 369846 [details] [review]:

Thanks, looks ok apart from small nitpick...

::: daemon/gvfsbackendmtp.c
@@ +1283,3 @@
+  g_free (mount_id);
+
+  g_file_info_set_attribute_string(info, G_FILE_ATTRIBUTE_ID_FILE, file_id);

nitpick: missing space before opening parenthesis
Comment 2 Philip Langdale 2018-03-20 03:14:52 UTC 
Pushed as 93067f4f