After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794446 - dconf doesn't build man pages when gtk-doc is disabled
dconf doesn't build man pages when gtk-doc is disabled
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
0.28.x
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-18 14:39 UTC by Rasmus Thomsen
Modified: 2018-08-08 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow manpages to be build, independant from gtk-doc (1.84 KB, patch)
2018-05-12 06:41 UTC, Koop Mast (kwm) 		committed Details | Review

Description Rasmus Thomsen 2018-03-18 14:39:30 UTC 
The meson.build in "docs" creates both the man pages and gtk-doc related documentation, but the main meson.build contains:

"
if get_option('enable-gtk-doc')
  subdir('docs')
endif
"

Which means that the meson.build in "docs" is only included if "enable-gtk-doc" is true. This means that the man pages won't be built if "enable-gtk-doc" is disabled
Comment 1 Koop Mast (kwm) 2018-05-12 06:41:17 UTC 
Created attachment 371949 [details] [review]
Allow manpages to be build, independant from gtk-doc

Instead of skipping docs in the !gtk-doc case, move the meson option check into docs/meson.build. This allows both gtk-doc and manpages to be build independantly from each other.
Comment 2 Philip Withnall 2018-08-08 11:17:54 UTC 
Review of attachment 371949 [details] [review]:

Looks good to me, thanks.
Comment 3 Philip Withnall 2018-08-08 11:20:07 UTC 
Pushed to master, thanks.