After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794380 - Build failure of gcocoanotificationbackend.c on OS X < 10.9
Build failure of gcocoanotificationbackend.c on OS X < 10.9
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.56.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-03-15 21:16 UTC by Ryan Schmidt
Modified: 2018-04-10 11:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build on OS X < 10.9 (506 bytes, patch)
2018-03-15 21:16 UTC, Ryan Schmidt 		committed Details | Review

Description Ryan Schmidt 2018-03-15 21:16:08 UTC 
Created attachment 369754 [details] [review]
Fix build on OS X < 10.9

This commit:

https://github.com/GNOME/glib/commit/170466db26818ade10862ff405698bb7a97d6d8e#diff-e1e6cbd7f58497c8dd2b4d20ea409408

which was released as part of glib 2.56.0 effectively reverted part of this commit:

https://github.com/GNOME/glib/commit/d1a03bc728df920d4da6db02437d99bba27aa20c#diff-e1e6cbd7f58497c8dd2b4d20ea409408

which had fixed building on OS X < 10.9. Hence building on OS X < 10.9 is broken again. The attached patch fixes this again.
Comment 1 Philip Withnall 2018-04-10 11:21:52 UTC 
Review of attachment 369754 [details] [review]:

Uff, yes.
Comment 2 Philip Withnall 2018-04-10 11:27:45 UTC 
Pushed to master and glib-2-56 (as 6106d18ae6b426a7d94fc9ec5129d5319016dfae).
Comment 3 Philip Withnall 2018-04-10 11:29:04 UTC 
Pushed to master as 9d27ed1d78d9b6df9059bb413809943082dc49ba, thanks git-bz for not including that information. ¬_¬