Created attachment 369739 [details] [review]
webrtc: Add some locks to setters and remove non-existing functions from headers

Created attachment 369740 [details] [review]
webrtc: Remove unused parameter from rtpsender constructor

(In reply to Sebastian Dröge (slomo) from comment #2)
> Created attachment 369740 [details] [review] [review]
> webrtc: Remove unused parameter from rtpsender constructor

This looks like a placeholder so that it can be used in the future, maybe we want to add G_GNUC_UNUSED to it instead?

I'm not entirely sure how this API is supposed to be used though. Should one look at the struct fields directly (in that case we should really add getters/setters for that).

Also in the ICE transport the setters could be GObject properties, I believe?

(In reply to Nirbheek Chauhan from comment #3)
> (In reply to Sebastian Dröge (slomo) from comment #2)
> > Created attachment 369740 [details] [review] [review] [review]
> > webrtc: Remove unused parameter from rtpsender constructor
> 
> This looks like a placeholder so that it can be used in the future, maybe we
> want to add G_GNUC_UNUSED to it instead?

I think all this API will change quite a bit. It seems better to not have an unused parameter there that people might think has an effect

Review of attachment 369739 [details] [review]:

Ack

Review of attachment 369740 [details] [review]:

Ack

Attachment 369739 [details] pushed as 950ead9 - webrtc: Add some locks to setters and remove non-existing functions from headers
Attachment 369740 [details] pushed as b1ca763 - webrtc: Remove unused parameter from rtpsender constructor