After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794362 - webrtc: Rename GstWebRTCIceRole to GstWebRTCICERole for consistency
webrtc: Rename GstWebRTCIceRole to GstWebRTCICERole for consistency
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal blocker
: 1.14.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-15 14:59 UTC by Sebastian Dröge (slomo)
Modified: 2018-03-16 08:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
webrtc: Rename GstWebRTCIceRole to GstWebRTCICERole for consistency (2.77 KB, patch)
2018-03-15 14:59 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-03-15 14:59:03 UTC 
.
Comment 1 Sebastian Dröge (slomo) 2018-03-15 14:59:09 UTC 
Created attachment 369738 [details] [review]
webrtc: Rename GstWebRTCIceRole to GstWebRTCICERole for consistency

Everything else is ICE, not Ice.
Comment 2 Matthew Waters (ystreet00) 2018-03-16 00:33:56 UTC 
Review of attachment 369738 [details] [review]:

Spec references should keep the spec capitalization.

::: gst-libs/gst/webrtc/dtlstransport.c
@@ +20,3 @@
 /**
  * SECTION:gstwebrtc-dtlstransport
+ * @short_description: RTCDTLSTransport object

Should keep the reference to the wsc spec the same capitalization: RTCDtlsTransport

::: gst-libs/gst/webrtc/icetransport.c
@@ +20,3 @@
 /**
  * SECTION:gstwebrtc-icetransport
+ * @short_description: RTCICETransport object

should keep the reference to the w3c spec the same capitalization: RTCIceTransport
Comment 3 Sebastian Dröge (slomo) 2018-03-16 08:37:36 UTC 
Attachment 369738 [details] pushed as dabfe39 - webrtc: Rename GstWebRTCIceRole to GstWebRTCICERole for consistency