GNOME Bugzilla – Bug 794326
Darwin build broken with meson
Last modified: 2018-08-30 09:23:39 UTC
FAILED: atk/libatk-1.0.0.dylib clang -o atk/libatk-1.0.0.dylib 'atk/atk-1.0@sha/meson-generated_.._atk-enum-types.c.o' 'atk/atk-1.0@sha/meson-generated_.._atkmarshal.c.o' 'atk/atk-1.0@sha/atkaction.c.o' 'atk/atk-1.0@sha/atkcomponent.c.o' 'atk/atk-1.0@sha/atkdocument.c.o' 'atk/atk-1.0@sha/atkeditabletext.c.o' 'atk/atk-1.0@sha/atkgobjectaccessible.c.o' 'atk/atk-1.0@sha/atkhyperlink.c.o' 'atk/atk-1.0@sha/atkhyperlinkimpl.c.o' 'atk/atk-1.0@sha/atkhypertext.c.o' 'atk/atk-1.0@sha/atkimage.c.o' 'atk/atk-1.0@sha/atknoopobject.c.o' 'atk/atk-1.0@sha/atknoopobjectfactory.c.o' 'atk/atk-1.0@sha/atkobject.c.o' 'atk/atk-1.0@sha/atkobjectfactory.c.o' 'atk/atk-1.0@sha/atkplug.c.o' 'atk/atk-1.0@sha/atkprivate.c.o' 'atk/atk-1.0@sha/atkrange.c.o' 'atk/atk-1.0@sha/atkregistry.c.o' 'atk/atk-1.0@sha/atkrelation.c.o' 'atk/atk-1.0@sha/atkrelationset.c.o' 'atk/atk-1.0@sha/atkselection.c.o' 'atk/atk-1.0@sha/atksocket.c.o' 'atk/atk-1.0@sha/atkstate.c.o' 'atk/atk-1.0@sha/atkstateset.c.o' 'atk/atk-1.0@sha/atkstreamablecontent.c.o' 'atk/atk-1.0@sha/atktable.c.o' 'atk/atk-1.0@sha/atktablecell.c.o' 'atk/atk-1.0@sha/atktext.c.o' 'atk/atk-1.0@sha/atkutil.c.o' 'atk/atk-1.0@sha/atkmisc.c.o' 'atk/atk-1.0@sha/atkvalue.c.o' 'atk/atk-1.0@sha/atkversion.c.o' 'atk/atk-1.0@sha/atkwindow.c.o' -Wl,-headerpad_max_install_names -shared -install_name @rpath/libatk-1.0.0.dylib -compatibility_version=1 -current_version=1.0 -L/nix/store/xga6mv79d0myq4hczkml64f314c8mwjy-glib-2.56.0/lib -lgobject-2.0 -lglib-2.0 ld: malformed 32-bit x.y.z version number: =1 clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation) See also the same problem with libepoxy: https://github.com/anholt/libepoxy/pull/128
Created attachment 369680 [details] [review] build: fix macOS common_ldflags
This patch seems to fix the build.
Review of attachment 369680 [details] [review]: LGTM, although fwiw, I can't test it. If you say that it fixes the build on macOs I rely on you. It is also a solution really similar to the one applied on libepoxy. Thanks for the patch.
Can this be committed? We have been applying this patch for few months and it works great.
(In reply to Jan Tojnar from comment #5) > Can this be committed? We have been applying this patch for few months and > it works great. Ups sorry. Usually when the reviewer sets it to accepted-commit_now status, the patch author commits it. Do you need me to push the commit?
I can push it but cannot change the patch status on Bugzilla.
Weird, I must have missed the status change. Also at the time I did not have commit access. Anyway, it is committed now.
(In reply to Jan Tojnar from comment #8) > Weird, I must have missed the status change. Also at the time I did not have > commit access. > > Anyway, it is committed now. Ok, thanks for the patch.