GNOME Bugzilla – Bug 794325
Various fixes to compile on OSX
Last modified: 2018-05-02 23:06:41 UTC
Created attachment 369662 [details] [review] patch A set of patches to make glib compile on OSX again.
Created attachment 369663 [details] [review] patch
Created attachment 369664 [details] [review] patch
Created attachment 369665 [details] [review] patch
Which version of GLib are these for? I’m a bit confused about the kqueue patches, because they apply to glib-2-56 (not master), but the kqueue backend was last changed in about 2015 — has it been failing to build on OS X for all this time? Does the rewritten version of the kqueue backend on GLib master compile for you? What version of OS X are you using? More generally, if these are patches for the glib-2-56 branch, then it means we’ve shipped GLib 2.56.0 as unbuildable on OS X. I’d really like to avoid that in future. What’s your interest in GLib on OS X? Would you be able to test it towards the end of the GNOME release cycle (https://wiki.gnome.org/Schedule), before the code freeze, so that we can stabilise GLib on OS X before the release? Or, better, would it be possible to set up an OS X CI machine for gitlab.gnome.org so that every GLib commit gets built and tested on OS X?
Hm, I thought I had rebased on master, but now that I try that again, I see the kqueue-patches are not applying anymore (as you said), and it builds for me! (albeit with quite a few sinister-looking warnings) The only patch still applies seems to be the libintl dependency. Sorry about that! My interest is unfortunately mainly a personal one. My company (Pexip) are committed to Linux (autotools moving to meson) and Windows (meson/msvc) so for those we are happy to test stuff before releases if that would help, but OSX is only kept alive by my own stubbornness since I am a big fan of exposing code to as many compilers and OSes as possible :) I am currently on 10.13 using Apple LLVM version 9.0.0 (clang-900.0.39.2).
I might also add that we keep all our patches on open-source projects in public repos, so the one I just built can be found here: https://github.com/pexip/glib/tree/v19
Created attachment 369690 [details] [review] kqueue/meson: add missing dependency I spoke too soon. Turns out that there was a missing dependency that I missed the first time around since the file (gioenumtypes.h) was already in my tree. A full clean revealed it though. I also obsoleted the other patches against 2.56, which should leave the two proper ones.
Ping?
Review of attachment 369662 [details] [review]: This was identically fixed as commit 24e80aac1fafd5d634017ed879bcc31b9938a75d (bug #794556).
Review of attachment 369690 [details] [review]: This looks good, thanks.
Sorry for the delay in getting back to you (thanks for pinging). Pushed to master! Attachment 369690 [details] pushed as 71fba3b - kqueue/meson: add missing dependency