After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794295 - Patches to reduce g-c-c Network panel delta
Patches to reduce g-c-c Network panel delta
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review 785099
 
 
Reported: 2018-03-13 15:56 UTC by Bastien Nocera
Modified: 2018-03-19 00:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wireless-security: Change labelling style (23.46 KB, patch)
2018-03-13 15:57 UTC, Bastien Nocera 		committed Details | Review
wireless-security: Make wireless_security_get_type() into a macro (3.70 KB, patch)
2018-03-13 15:57 UTC, Bastien Nocera 		committed Details | Review
connection-editor: Change labelling style (137.70 KB, patch)
2018-03-13 16:24 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2018-03-13 15:56:56 UTC 
Some small changes to help reduce the delta with g-c-c.
Comment 1 Bastien Nocera 2018-03-13 15:57:02 UTC 
Created attachment 369626 [details] [review]
wireless-security: Change labelling style

Replace the left justified labels with right justified ones, reduce the
space between label and entry and drop the unnecessary ":". This more
closely matches the GNOME UI style, reducing the differences between
gnome-control-center's Network panel and nm-applet.
Comment 2 Bastien Nocera 2018-03-13 15:57:09 UTC 
Created attachment 369627 [details] [review]
wireless-security: Make wireless_security_get_type() into a macro

And use WIRELESS_TYPE_SECURITY, rather than calling out to
wireless_security_get_type() directly. This looks nicer in GtkListStore
definitions.
Comment 3 Bastien Nocera 2018-03-13 16:24:08 UTC 
Created attachment 369628 [details] [review]
connection-editor: Change labelling style

Replace the left justified labels with right justified ones, reduce the
space between label and entry and drop the unnecessary ":". This more
closely matches the GNOME UI style, reducing the differences between
gnome-control-center's Network panel and nm-applet.
Comment 4 Thomas Haller 2018-03-14 18:23:52 UTC 
all 3 patches lgtm
Comment 5 Bastien Nocera 2018-03-19 00:50:17 UTC 
Attachment 369626 [details] pushed as e1a0b88 - wireless-security: Change labelling style
Attachment 369627 [details] pushed as ed74123 - wireless-security: Make wireless_security_get_type() into a macro
Attachment 369628 [details] pushed as 004ac2a - connection-editor: Change labelling style