After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794272 - Initialize write buffer to avoid valgrind warning
Initialize write buffer to avoid valgrind warning
Status: RESOLVED FIXED
Product: sysprof
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Sysprof maintainer(s)
Sysprof maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-03-12 23:37 UTC by Philip Chimento
Modified: 2018-03-12 23:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sp-capture-writer: Initialize write buffer (1.07 KB, patch)
2018-03-12 23:37 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2018-03-12 23:37:37 UTC 
Valgrind complains that this buffer is not fully initialized.
Comment 1 Philip Chimento 2018-03-12 23:37:43 UTC 
Created attachment 369593 [details] [review]
sp-capture-writer: Initialize write buffer

Valgrind notes that the buffer is not fully initialized when we pass it
to write(). This could potentially write sensitive data, if we are not
careful with the buffer length.

See https://gitlab.gnome.org/GNOME/gjs/issues/120
Comment 2 Christian Hergert 2018-03-12 23:52:04 UTC 
Sure, LGTM

Attachment 369593 [details] pushed as c3d1fd0 - sp-capture-writer: Initialize write buffer