After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794238 - Internal libgnome-libchess.so library is installed system wide
Internal libgnome-libchess.so library is installed system wide
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: Michael Catanzaro
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-11 15:03 UTC by Kalev Lember
Modified: 2018-03-11 23:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libchess should be a static convenience library (922 bytes, patch)
2018-03-11 17:41 UTC, Michael Catanzaro
committed Details | Review
Tests should not be installed (769 bytes, patch)
2018-03-11 17:42 UTC, Michael Catanzaro
committed Details | Review

Description Kalev Lember 2018-03-11 15:03:13 UTC
Looks like a regression from the meson port. With the autotools build, libgnome-libchess.so was a static library, but now it's installed system wide as a shared library. I don't think that's intentional, because it's as far as I can tell supposed to be a private library.

I'd do one of the following:

 - change it to be a static library that's only linked into gnome-chess
 - move it to a private directory, such as /usr/lib/gnome-chess/libgnome-libchess.so
 - turn it into a proper shared library, with soname etc that it's currently lacking
Comment 1 Michael Catanzaro 2018-03-11 16:31:56 UTC
Did you skip both the 3.27 releases? This would have been nice to have known about yesterday. :(

(In reply to Kalev Lember from comment #0)
>  - change it to be a static library that's only linked into gnome-chess
>  - move it to a private directory, such as
> /usr/lib/gnome-chess/libgnome-libchess.so

Probably a non-installed static library would be better, but either way would be fine.

>  - turn it into a proper shared library, with soname etc that it's currently
> lacking

No thanks!
Comment 2 Michael Catanzaro 2018-03-11 17:41:16 UTC
The following fix has been pushed:
c2292dd libchess should be a static convenience library
Comment 3 Michael Catanzaro 2018-03-11 17:41:27 UTC
Created attachment 369551 [details] [review]
libchess should be a static convenience library

This shouldn't be installed as a shared library
Comment 4 Michael Catanzaro 2018-03-11 17:42:16 UTC
The following fix has been pushed:
036d355 Tests should not be installed
Comment 5 Michael Catanzaro 2018-03-11 17:42:21 UTC
Created attachment 369552 [details] [review]
Tests should not be installed

These are getting installed into /usr/bin
Comment 6 Michael Catanzaro 2018-03-11 17:43:11 UTC
(In reply to Michael Catanzaro from comment #4)
> The following fix has been pushed:
> 036d355 Tests should not be installed

I meant to attach this to bug #794239, of course.
Comment 7 Jeremy Bicha 2018-03-11 18:30:43 UTC
Michael, could you delete data/pieces/fancy/Makefile.am too?
Comment 8 Kalev Lember 2018-03-11 19:38:28 UTC
Thanks Michael!
Comment 9 Michael Catanzaro 2018-03-11 23:26:25 UTC
(In reply to Jeremy Bicha from comment #7)
> Michael, could you delete data/pieces/fancy/Makefile.am too?

Yup, thanks for noticing it.