After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794215 - segment: Change back gst_segment_do_seek() to use gint64
segment: Change back gst_segment_do_seek() to use gint64
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-09 19:01 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-11-03 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2018-03-09 19:01:21 UTC 
During 0.11 dev at commit bdbc069348 the gst_segment_do_seek() was changed to accept only unsigned start/stop. Though, the code will do direct comparision with -1 and also assumes negative values for GST_SEEK_TYPE_END:

  start = segment->duration + start;

Additionally, the gst_event_new_seek() API along with the GstElement API uses signed integer. Demuxers will pass these value unchecked to that API in order to update their segment. Looking at the code, it will properly wrap around resulting in the same behaviour, but it's all a bit of a lie. As this does not affect the API, I think it's fine to switch it back to gint64.
Comment 1 GStreamer system administrator 2018-11-03 12:45:05 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/278.