After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794186 - kmssink: Add 24bit RGB support
kmssink: Add 24bit RGB support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-08 21:14 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-04-26 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
kmssink: Add 24bit RGB support (1.13 KB, patch)
2018-03-08 21:14 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2018-03-08 21:14:08 UTC 
This adds 24bit RGB support to kmssink. This patch was tested with
xilinx_drm driver.
Comment 1 Nicolas Dufresne (ndufresne) 2018-03-08 21:14:14 UTC 
Created attachment 369472 [details] [review]
kmssink: Add 24bit RGB support
Comment 2 Olivier Crête 2018-03-08 21:30:15 UTC 
Review of attachment 369472 [details] [review]:

::: sys/kms/gstkmsutils.c
@@ +56,3 @@
   DEF_FMT (XBGR8888, xBGR),
+  DEF_FMT (RGB888, RGB),
+  DEF_FMT (BGR888, BGR),

shouldn't this be right after the #endif instead of duplicating it ?
Comment 3 Nicolas Dufresne (ndufresne) 2018-03-08 21:42:37 UTC 
Review of attachment 369472 [details] [review]:

::: sys/kms/gstkmsutils.c
@@ +56,3 @@
   DEF_FMT (XBGR8888, xBGR),
+  DEF_FMT (RGB888, RGB),
+  DEF_FMT (BGR888, BGR),

The mapping differ between Big and Little Endian.
Comment 4 Nicolas Dufresne (ndufresne) 2018-04-26 14:47:39 UTC 
Attachment 369472 [details] pushed as 673e7a7 - kmssink: Add 24bit RGB support