Created attachment 369383 [details] [review]
devices: Set NM_METERED_GUESS_YES for Bluetooth and WiMAX connections

Bluetooth tethering is a common way to expose a metered 3G or 4G
connection from a phone to a laptop. WiMAX is in the same family of
mobile internet connections as the other GUESS_YES metered connection
types.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Seems reasonable, but maybe we should set GUESS_YES only for PANU/DUN bluetooth connections and not for NAP (where we share the connectivity to another device)?

I agree with Beniamino.

Also, WiMAX is essentially removed from NetworkManager. It only still exists in the libnm API to not break API. But you cannot do anything with it, especially, you cannot activate such a profile. Let's not set metered for WiMAX connections, the code will never be reached.

Created attachment 369436 [details] [review]
devices: Set NM_METERED_GUESS_YES for Bluetooth PANU/DUN connections

Bluetooth tethering using DUN or PANU is a common way to expose a
metered 3G or 4G connection from a phone to a laptop. We deliberately
ignore NAP connections, which is where we’re sharing internet from the
laptop to another device.

We could also set GUESS_YES for WiMAX connections, but NetworkManager
doesn’t support them any more. Add a comment about that.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

merged to master as https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=599da6fd02039e8b5b78953d2c517a62e5a08a4a


with a follow-up https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=d76cfa3814915cc12c7af9e7bdc4d7ac3dc71e49


Thank you!!