GNOME Bugzilla – Bug 794088
Add calls to g_simple_async_result_set_check_cancellable
Last modified: 2018-03-08 14:50:19 UTC
If an operation is cancelled through the GCancellable, then the idiom is that the operation is always cancelled, even if it has finished successfully. To ensure this is the case, add calls to g_simple_async_result_set_check_cancellable everywhere. Without this, e.g. gnome-control-center will crash when switching away from the power panel quickly, as the NMClient creation finishes asynchronously and g-c-c assume that G_IO_ERROR_CANCELLED is returned to ensure it doesn't access the now invalid user_data parameter.
Created attachment 369349 [details] [review] Add calls to g_simple_async_result_set_check_cancellable
lgtm
Merged master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=26c215e22dcfff9e61a58e9348991ed77c3f8861 and backported to: nm-1-10: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e1b99d92013303b921740bbd1ff862f11c7564dd nm-1-8: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2e628535097cf28177feb20bd5277d02e8e2a3b5 nm-1-6: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4bcb4c4ef254c34f2611b1a5f5240025f42e95e1 nm-1-4: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=55d749f9407e40a050484565c4c84d684115114a Thanks!!