After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794051 - rebase: fix on-line location extraction from devhelp files
rebase: fix on-line location extraction from devhelp files
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.27
Other Linux
: Normal major
: 1.28
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-05 00:41 UTC by Tim-Philipp Müller
Modified: 2018-05-10 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rebase: fix on-line location extraction from devhelp files (1.24 KB, patch)
2018-03-05 00:41 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2018-03-05 00:41:14 UTC
Created attachment 369280 [details] [review]
rebase: fix on-line location extraction from devhelp files

"make upload" in gstreamer would fail because gtkdoc-rebase didn't find online locations from installed devhelp files, which is a regression.

Attached patch seems to fix this for me.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2018-03-19 19:20:01 UTC
I am sorry, looks like more fallout from perl to python porting. Thanks for the patch.
Comment 2 Adam Williamson 2018-05-10 18:54:12 UTC
Just as a note, we (halfline and I) think this revealed two further bugs that were kinda hidden by the overly specific regex before:

https://bugzilla.gnome.org/show_bug.cgi?id=796011
https://bugzilla.gnome.org/show_bug.cgi?id=796012

he ran into both of those while trying to do an accountsservice release with gtk-doc 1.28. I think, with 1.27 and earlier, the ReadDevhelp regex failed to match, so it returned None, so `ScanDirectory` didn't hit the fateful attempt to call `ReadIndex` which runs into both those bugs.