GNOME Bugzilla – Bug 794051
rebase: fix on-line location extraction from devhelp files
Last modified: 2018-05-10 18:54:12 UTC
Created attachment 369280 [details] [review] rebase: fix on-line location extraction from devhelp files "make upload" in gstreamer would fail because gtkdoc-rebase didn't find online locations from installed devhelp files, which is a regression. Attached patch seems to fix this for me.
I am sorry, looks like more fallout from perl to python porting. Thanks for the patch.
Just as a note, we (halfline and I) think this revealed two further bugs that were kinda hidden by the overly specific regex before: https://bugzilla.gnome.org/show_bug.cgi?id=796011 https://bugzilla.gnome.org/show_bug.cgi?id=796012 he ran into both of those while trying to do an accountsservice release with gtk-doc 1.28. I think, with 1.27 and earlier, the ReadDevhelp regex failed to match, so it returned None, so `ScanDirectory` didn't hit the fateful attempt to call `ReadIndex` which runs into both those bugs.