After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794040 - gst-rtsp-server: allow access to receive RTCP pad in gst-rtsp-stream
gst-rtsp-server: allow access to receive RTCP pad in gst-rtsp-stream
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-04 12:23 UTC by Felix Herbeck
Modified: 2018-03-08 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for rtsp-stream.c (816 bytes, application/octet-stream)
2018-03-04 12:23 UTC, Felix Herbeck
  Details
patch for rtsp-stream.h (630 bytes, application/octet-stream)
2018-03-04 12:24 UTC, Felix Herbeck
  Details
patch in git format-patch format (1.84 KB, patch)
2018-03-08 14:58 UTC, Felix Herbeck
rejected Details | Review

Description Felix Herbeck 2018-03-04 12:23:15 UTC
Created attachment 369263 [details]
patch for rtsp-stream.c

The possibility to do external incoming RTCP parsing for a lot of different purposes such as serving the intra frame on FIR request or running advanced bitrate adaptation algorithms requires the ability to connect a probe to receive RTCP pad pf gst-rtsp-stream object. It can be done in exactly the same manner as the capability of getting the incoming and outgoing RTP pads of the same object that already implemented.

The proposed patch is in the attachment to this feature request
Comment 1 Felix Herbeck 2018-03-04 12:24:01 UTC
Created attachment 369264 [details]
patch for rtsp-stream.h
Comment 2 Sebastian Dröge (slomo) 2018-03-05 08:14:36 UTC
Thanks! Please provide patches in "git format-patch" format though, this allows direct merging and review here inside Bugzilla.
Comment 3 Felix Herbeck 2018-03-08 14:58:19 UTC
Created attachment 369453 [details] [review]
patch in git format-patch format
Comment 4 Sebastian Dröge (slomo) 2018-03-08 15:58:41 UTC
Comment on attachment 369453 [details] [review]
patch in git format-patch format

You can get the rtpsession from the rtpbin of the stream, and it has various signals to handle RTCP packets. E.g. "on-sending-rtcp" for when sending of RTCP happens, "on-receiving-rtcp" for when an RTCP packet was received, "send-rtcp"/"send-rtcp-full" to request a new RTCP packet to be sent (you can attach new things in "on-sending-rtcp" to the packet) and various specific "on-***-rtcp" signals.
Comment 5 Sebastian Dröge (slomo) 2018-03-08 15:59:36 UTC
Also FIR and similar packets are already handled internally and translated to GStreamer specific events.


Do you see anything missing still that would require more API to be added, or any API that does not work as required?