After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794002 - Occasionally segfauls at exit
Occasionally segfauls at exit
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2018-03-02 21:26 UTC by Marcus Lundblad
Modified: 2018-03-02 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
contactStore: Don't transfer ownership of contacts (1.03 KB, patch)
2018-03-02 21:26 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2018-03-02 21:26:06 UTC
maps_contact_store_get_contacts() transfers ownership of the GList returned to the caller, while the class frees the list in _dispose(), so the list should remain the ownership of the callee.
Comment 1 Marcus Lundblad 2018-03-02 21:26:41 UTC
Created attachment 369204 [details] [review]
contactStore: Don't transfer ownership of contacts

Don't transfer ownership of list returned by
maps_contact_store_get_contacts(), as the contact
store instance frees it when getting disposed.
Comment 2 Marcus Lundblad 2018-03-02 21:28:03 UTC
Attachment 369204 [details] pushed as 271c2b6 - contactStore: Don't transfer ownership of contacts