After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793964 - rtspsrc: regression with streams marked as recvonly
rtspsrc: regression with streams marked as recvonly
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 793715
Blocks:
 
 
Reported: 2018-03-01 18:31 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2018-03-01 18:31:36 UTC
+++ This bug was initially created as a clone of Bug #793715 +++

We should find a way to enable filtering by recvonly/sendonly attributes again for the general case. Otherwise streams with recvonly (as in: the server wants to receive data from us) would not work in rtspsrc because we create a pad for those streams and it will never get any data.

Should be solved for 1.16.
Comment 1 Sebastian Dröge (slomo) 2018-04-11 08:26:38 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=792376#c4

> The RTSP RFCs actually define it the other way around, that is how it was
> before the commit that "fixed" this bug.
> 
> https://tools.ietf.org/html/rfc2326#page-31 and
> https://tools.ietf.org/html/rfc7826#appendix-D.1.5 for example say that
> "recvonly" is for streams that go from the server to the client.
> 
> This is in direct contradiction to RFC 3264 which says that the offerer
> (i.e. the server in our case) should use "sendonly" if it only wants to send
> a stream to its peer (the client).
> 
> 
> So in summary, the RTSP RFCs clearly say how it should be and that's the
> other way around than it is defined in the SDP RFC.

That means a) it was correct for RTSP before, and b) there are RTSP servers that are doing it wrong (they do it according to the SDP RFC).

So we need to change the default behaviour in gst-rtsp-server again, and in rtspsrc too probably and provide a property to change it back for broken servers/clients.
Comment 2 Sebastian Dröge (slomo) 2018-04-16 08:24:14 UTC
We should probably revert the behaviour for 1.14.1 so that the broken behaviour was only in a single release.

And then consider adding a property to rtspsrc to filter streams, defaulting to nothing and allowing to filter for both behaviours.
Comment 3 Sebastian Dröge (slomo) 2018-04-17 14:58:53 UTC
commit 6d92fcd04394cf6a5cd7d316fb4f876aae72890d (HEAD -> master)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Apr 17 17:57:16 2018 +0300

    Revert "rtspsrc: Fix up sendonly/recvonly attribute handling"
    
    This reverts commit af273b4de9eb292c0b6af63665e10ca015895902.
    
    While RFC 3264 (SDP) says that sendonly/recvonly are from the point of view of
    the requester, the actual RTSP RFCs (RFC 2326 / 7826) disagree and say
    the opposite, just like the ONVIF standard.
    
    Let's follow those RFCs as we're doing RTSP here, and add a property at
    a later time if needed to switch to the SDP RFC behaviour.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793964


commit 9f5d3ee7a8ccf92b883e9e6a31151cb3d45bf7a9 (HEAD -> master, origin/master, origin/HEAD)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Apr 17 17:47:30 2018 +0300

    Revert "rtsp-server: Switch around sendonly/recvonly attributes"
    
    This reverts commit 3d275b1345b76151418e3f56ed014d9089ac1a57.
    
    While RFC 3264 (SDP) says that sendonly/recvonly are from the point of view of
    the requester, the actual RTSP RFCs (RFC 2326 / 7826) disagree and say
    the opposite, just like the ONVIF standard.
    
    Let's follow those RFCs as we're doing RTSP here, and add a property at
    a later time if needed to switch to the SDP RFC behaviour.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793964
Comment 4 Sebastian Dröge (slomo) 2018-04-17 14:59:08 UTC
Let's add the properties later
Comment 5 GStreamer system administrator 2018-11-03 15:26:46 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/445.