After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793955 - Missing quote in action response XML
Missing quote in action response XML
Product: GUPnP
Classification: Other
Component: gupnp
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Reported: 2018-03-01 15:44 UTC by Sven Neumann
Modified: 2018-03-17 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Proposed fix (835 bytes, patch)
2018-03-01 15:48 UTC, Sven Neumann
rejected Details | Review
Patch suggestion (1.11 KB, patch)
2018-03-01 17:25 UTC, Jens Georg
committed Details | Review

Description Sven Neumann 2018-03-01 15:44:39 UTC
The GUPnPServiceProxy creates invalid XML in the action response:

<?xml version="1.0"?><s:Envelope xmlns:s="" s:encodingStyle=""><s:Body><u:GetMuteResponse xmlns:u=urn:upnp-org:serviceId:RenderingControl"><CurrentMute>0</CurrentMute></u:GetMuteResponse></s:Body></s:Envelope>

There is an opening quote missing in
Comment 1 Sven Neumann 2018-03-01 15:48:35 UTC
Created attachment 369146 [details] [review]
Proposed fix

The attached patch should fix the problem. The code will still create questionable XML if the service_type isn't set, but that's a different issue.
Comment 2 Sven Neumann 2018-03-01 16:16:52 UTC
Interesting, it seems that I had fixed this years ago already, but for some undocumented reason Zeeshan reverted it on the next day:

commit 481f399f80a6eaa5c30a77e2a5539e5f967c84df
Author: Zeeshan Ali (Khattak) <>
Date:   Fri Feb 18 11:45:57 2011 +0200

    Revert "Add missing quote in action response"
    This reverts commit 1ff7bd81f152b2579744fe2de46fb709cf51f279.

commit 1ff7bd81f152b2579744fe2de46fb709cf51f279
Author: Sven Neumann <>
Date:   Thu Feb 17 17:57:57 2011 +0100

    Add missing quote in action response
    The action response document was missing an opening quote
    sign in the namespace declaration of the <actionResponse>
    Fix it by adding the missing quote and also tweak the code
    a bit to output well-formed XML in case that the service-type
    is not set.
Comment 3 Sven Neumann 2018-03-01 16:59:49 UTC
Found the reason for the revert in the mailing-list archives:

OK, so the root of problem was actually on the client. But maybe the code should still be changed because

(a) It created invalid XML in response to an invalid request. Maybe it should rather respond with an error so that people fix their clients, or alternatively deal gracefully with the client error and produce a valid response.

(b) The looks obviously wrong and there is no comment explaining why there's an unbalanced quote added.
Comment 4 Sven Neumann 2018-03-01 17:00:54 UTC
Review of attachment 369146 [details] [review]:

This patch is wrong.
Comment 5 Jens Georg 2018-03-01 17:06:45 UTC
I vaguely remember this discussion as well
Comment 6 Jens Georg 2018-03-01 17:14:17 UTC
So this code assumes well-quoted SOAP-Action header? That's probably not that wise.
Comment 7 Jens Georg 2018-03-01 17:25:42 UTC
Created attachment 369156 [details] [review]
Patch suggestion
Comment 8 Sven Neumann 2018-03-02 09:31:58 UTC
Review of attachment 369156 [details] [review]:

Looks good to me. I've run our automated tests against a system that has this patch applied and did not run into any problems.