After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793920 - Print summary of enabled build options in meson.build
Print summary of enabled build options in meson.build
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2018-02-28 15:26 UTC by Bastien Nocera
Modified: 2018-03-05 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Print summary of the options (3.15 KB, patch)
2018-02-28 16:15 UTC, Iñigo Martínez
none Details | Review
build: Print summary of the options (3.91 KB, patch)
2018-03-01 09:20 UTC, Ondrej Holy
committed Details | Review

Description Bastien Nocera 2018-02-28 15:26:30 UTC
As is done at the end of the autotools configure.ac:
https://git.gnome.org//browse/gvfs/tree/configure.ac#n800

Makes it easier to see whether a particular backend was built.
Comment 1 Ondrej Holy 2018-02-28 16:00:02 UTC
There isn't any summary because auto-options were removed, so the configuration is deterministically based on meson_options.txt currently. Also you can print nice overview using "meson configure". So I think there isn't any need for some custom summary. Isn't this enough for you?
Comment 2 Bastien Nocera 2018-02-28 16:07:20 UTC
I'd rather have that information at the end of the "meson" step, so I don't have to go look anywhere but in the build logs for this information.

totem prints that information, so does gnome-control-center and gnome-settings-daemon.

See also: https://github.com/mesonbuild/meson/issues/757
Comment 3 Iñigo Martínez 2018-02-28 16:15:38 UTC
Created attachment 369106 [details] [review]
build: Print summary of the options

Here goes a patch that adds again the options summary.

However, this was already discussed during the `meson port` bug (bug 786149), and the conclussion was that `meson configure` would be enough for this.
Comment 4 Ondrej Holy 2018-03-01 09:20:39 UTC
Review of attachment 369106 [details] [review]:

Thanks, Inigo. It would be nice to do it somehow automatically, but if I recall correctly, there isn't any way to get a list of project options :-(

But ok, I am not against if this help to one of the remaining contributors - thanks hadess for your work here! However, in this case, I don't want to add the old summary, but I would like to use names and order from meson_options.txt...
Comment 5 Ondrej Holy 2018-03-01 09:20:52 UTC
Created attachment 369137 [details] [review]
build: Print summary of the options

What about this?
Comment 6 Iñigo Martínez 2018-03-01 09:30:28 UTC
LGTM. I suppose it will work until meson has some similar feature like the one mentioned at comment 2.
Comment 7 Ondrej Holy 2018-03-05 13:33:51 UTC
So let's go with this...

Attachment 369137 [details] pushed as 1f2977d - build: Print summary of the options