After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793878 - Plug a leak in gnome_bg_slide_show_load_async()
Plug a leak in gnome_bg_slide_show_load_async()
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: Background
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 793854 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-02-27 13:26 UTC by Carlos Garnacho
Modified: 2018-05-01 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-bg: Plug GTask leak on gnome_bg_slide_show_load_async() (1.10 KB, patch)
2018-02-27 13:27 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2018-02-27 13:26:52 UTC
It is leaking the GTask object.
Comment 1 Carlos Garnacho 2018-02-27 13:27:36 UTC
Created attachment 369023 [details] [review]
gnome-bg: Plug GTask leak on gnome_bg_slide_show_load_async()
Comment 2 Bastien Nocera 2018-02-27 13:51:20 UTC
Review of attachment 369023 [details] [review]:

Looks good.
Comment 3 Bastien Nocera 2018-02-27 13:52:10 UTC
Please also cherry-pick for gnome-3-26
Comment 4 André Klapper 2018-04-17 17:29:13 UTC
Carlos: Any plans to commit this?
Comment 5 André Klapper 2018-04-17 17:30:30 UTC
*** Bug 793854 has been marked as a duplicate of this bug. ***
Comment 6 Carlos Garnacho 2018-04-17 17:45:57 UTC
Sorry, dropped off the radar... Pushed Florian's patch to master/gnome-3-28
Comment 7 Scott Reeves 2018-05-01 21:02:31 UTC
(In reply to Bastien Nocera from comment #3)
> Please also cherry-pick for gnome-3-26

Done - commit f2aca1689