After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793859 - Don't put a warning on missing error on private dbus method
Don't put a warning on missing error on private dbus method
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
unspecified
Other Linux
: Normal normal
: 0.40
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-26 19:43 UTC by Corentin Noël
Modified: 2018-02-27 08:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
No error on private method (1.05 KB, patch)
2018-02-26 19:44 UTC, Corentin Noël 		none Details | Review
method: Check with same rules for dbus compatibility as in GBusModule (1.40 KB, patch)
2018-02-26 20:15 UTC, Rico Tzschichholz 		none Details | Review
method: Check with same rules for dbus compatibility as in GBusModule (1.40 KB, patch)
2018-02-26 22:32 UTC, Rico Tzschichholz 		committed Details | Review

Description Corentin Noël 2018-02-26 19:43:53 UTC 
For a DBus server, if it's private it won't be available.
Comment 1 Corentin Noël 2018-02-26 19:44:43 UTC 
Created attachment 368972 [details] [review]
No error on private method
Comment 2 Rico Tzschichholz 2018-02-26 20:15:38 UTC 
Created attachment 368976 [details] [review]
method: Check with same rules for dbus compatibility as in GBusModule

Only issue warning if the method would actually be end up on DBus as
per generate_interface_method_call_function() or get_method_info().

Based on patch by Corentin Noël
Comment 3 Rico Tzschichholz 2018-02-26 22:32:16 UTC 
Created attachment 368981 [details] [review]
method: Check with same rules for dbus compatibility as in GBusModule

Only issue warning if the method would actually be end up on DBus as
per generate_interface_method_call_function() or get_method_info().

Based on patch by Corentin Noël
Comment 4 Rico Tzschichholz 2018-02-27 08:17:56 UTC 
Attachment 368981 [details] pushed as 3c8c079 - method: Check with same rules for dbus compatibility as in GBusModule