After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793852 - Remove unused code after changes for bug 793466
Remove unused code after changes for bug 793466
Status: RESOLVED DUPLICATE of bug 793466
Product: evolution-data-server
Classification: Platform
Component: general
3.26.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2018-02-26 17:40 UTC by Lubomir Rintel
Modified: 2018-02-27 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] ESource: avoid queueing "changed" emission during initialization (2.49 KB, patch)
2018-02-26 17:40 UTC, Lubomir Rintel
none Details | Review

Description Lubomir Rintel 2018-02-26 17:40:18 UTC
Created attachment 368955 [details] [review]
[PATCH] ESource: avoid queueing "changed" emission during initialization

Since [deade53 "Prevent early free of an ESource when it has pending
operations"] the idle changed emmission takes a reference to the object
before it busily spins until the end of object initialization.

However, when the initable subclass initialization fails, it spins forever.
This happened with an empty source file (presumably left in place after
a crash):

   $ >~/.config/evolution/sources/1430226322.3948.1@belphegor.source
   ** Failed to load key file at 'file:///...': Data source is missing a [Data Source] group
   (100% CPU consumption at this point)

At the end of source_initable_init() the delayed changed signals would
be destroyed anyway -- let's not enqueue them in the first place.
---
 src/libedataserver/e-source.c | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)
Comment 1 Milan Crha 2018-02-26 17:56:51 UTC
Thanks for a bug report and patch. This had been fixed recently at bug #793466, thus I mark this as a duplicate of it.

*** This bug has been marked as a duplicate of bug 793466 ***
Comment 2 Milan Crha 2018-02-27 09:19:23 UTC
I took your changes and slightly extended them and committed it to the sources:

Created commit f5d1dd610 in eds master (3.27.92+)
Created commit 77a521390 in eds gnome-3-26 (3.26.6+)