GNOME Bugzilla – Bug 793852
Remove unused code after changes for bug 793466
Last modified: 2018-02-27 09:19:23 UTC
Created attachment 368955 [details] [review] [PATCH] ESource: avoid queueing "changed" emission during initialization Since [deade53 "Prevent early free of an ESource when it has pending operations"] the idle changed emmission takes a reference to the object before it busily spins until the end of object initialization. However, when the initable subclass initialization fails, it spins forever. This happened with an empty source file (presumably left in place after a crash): $ >~/.config/evolution/sources/1430226322.3948.1@belphegor.source ** Failed to load key file at 'file:///...': Data source is missing a [Data Source] group (100% CPU consumption at this point) At the end of source_initable_init() the delayed changed signals would be destroyed anyway -- let's not enqueue them in the first place. --- src/libedataserver/e-source.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-)
Thanks for a bug report and patch. This had been fixed recently at bug #793466, thus I mark this as a duplicate of it. *** This bug has been marked as a duplicate of bug 793466 ***
I took your changes and slightly extended them and committed it to the sources: Created commit f5d1dd610 in eds master (3.27.92+) Created commit 77a521390 in eds gnome-3-26 (3.26.6+)