After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793795 - Use EUrlEntry in HTML editor's Link Properties dialog
Use EUrlEntry in HTML editor's Link Properties dialog
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Composer
3.26.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2018-02-24 15:24 UTC by Jean-François Fortin Tam
Modified: 2019-06-07 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mockup (26.60 KB, image/png)
2018-02-24 15:24 UTC, Jean-François Fortin Tam
Details
mockup with tooltip (31.86 KB, image/png)
2018-02-24 15:25 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2018-02-24 15:24:47 UTC
Created attachment 368873 [details]
mockup

In line with bug #756060, to create additional space savings and efficiency, I would recommend that we remove the big "Test URL..." button on the right of the URL GtkEntry, and replace it by a GtkEntry "secondary icon". The button is huge (especially in non-English locales), taking away space that could be used for the URL itself.

My recommendation for its replacement is to set these properties onto the URL GtkEntry:

secondary-icon-name = "go-jump" (this is the recommended way as per https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-JUMP-TO:CAPS ...)

secondary-icon-tooltip-text = "Click to test this link by opening it in your web browser" (translatable of course)

And then connecting to the secondary-icon's activated signal like you would with a normal button.

Attaching a simulation of what it would look (and behave) like, done with the Gtk Inspector.
Comment 1 Jean-François Fortin Tam 2018-02-24 15:25:17 UTC
Created attachment 368874 [details]
mockup with tooltip
Comment 2 Milan Crha 2019-06-07 14:41:29 UTC
Thanks for a bug report. Evolution already has a suitable widget for it, it's used in the Tasks properties, thus this change is pretty simple.
Comment 3 Milan Crha 2019-06-07 14:46:03 UTC
Created commit [1] in evo master (3.33.3+)

[1] https://gitlab.gnome.org/GNOME/evolution/commit/abb98547ee