Created attachment 368865 [details] [review]
rtspclientsink: allow setting payloader as pad property

Created attachment 368887 [details] [review]
rtspclientsink: allow setting payloader as pad property

This was a FIXME  item, and can be quite useful, also
allowing to specify payloader properties from the command
line, which is always nice.

You changed the pad template name from stream_%u to sink_%u, was that on purpose?

And how about we make it a GstElement * and let parse-launch do the element creation from the string? That's more consistent with similar properties elsewhere I think? (muxer in splitmuxsink, audio-sink in playbin etc.)

Review of attachment 368887 [details] [review]:

::: gst/rtsp-sink/gstrtspclientsink.c
@@ +184,3 @@
+      g_param_spec_string ("payloader", "payloader factory name",
+          "The name of the payloader factory to use", NULL,
+          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Why as a string? We could take an actual element (gst-launch has some magic to allow any parse-launch string then) here instead

@@ +1283,3 @@
+        /* User-specified payloader, which we haven't constructed yet,
+         * caps could be any */
+        caps = gst_caps_new_any ();

Then this could also take the caps :)

(In reply to Tim-Philipp Müller from comment #3)
> You changed the pad template name from stream_%u to sink_%u, was that on
> purpose?


Ah right, included it in this commit, the actual request code names them with the sink_%u format, thought that should be corrected


> Why as a string? We could take an actual element (gst-launch has some magic to allow any parse-launch string then) here instead

Ah, didn't know about the magic, will fix!

Created attachment 368954 [details] [review]
rtspclientsink: allow setting payloader as pad property

This was a FIXME  item, and can be quite useful, also
allowing to specify payloader properties from the command
line, which is always nice.

Attachment 368954 [details] pushed as 731c464 - rtspclientsink: allow setting payloader as pad property